A collection of small fixes #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 6, 2018 14:09
chunyong-lin
approved these changes
Mar 7, 2018
| resources = ["*"] | ||
| } | ||
| } | ||
|
|
||
| resource "aws_appautoscaling_target" "dynamodb_table_read_target" { | ||
| count = "${var.autoscale ? 1 : 0}" |
There was a problem hiding this comment.
Can you also help remove this line and autoscale variable? Because deleting custom static IAM role, it implies the autoscaling is enable all the time and can not be disabled.
There was a problem hiding this comment.
There is another line below should be deleted.
There was a problem hiding this comment.
Good idea, thanks!
| @@ -13,6 +13,7 @@ | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| """ | |||
| from __future__ import absolute_import # Suppresses RuntimeWarning import error in Lambda | |||
austinbyers
added a commit
that referenced
this pull request
Mar 12, 2018
austinbyers
added a commit
that referenced
this pull request
Mar 12, 2018
This was referenced Mar 12, 2018
ryandeivert
pushed a commit
that referenced
this pull request
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @chunyong-lin
cc: @airbnb/streamalert-maintainers
size: small|medium|large
resolves: #267
resolves: #572
Background
A collection of small fixes and features that I've accumulated
Changes
terraform fmtto fix a spacing issue which snuck inthird_party_librariesconfig option is generally only applicable to the rule processor, where users can specify additional libraries to install for their rules to work. To reduce confusion, this config option has been removed from the other default lambda configs (although it will still work for other functions if it is defined).I have no idea why it works, but I found this solution in the PyCharm blog
Testing
terraform validate